[ https://issues.apache.org/jira/browse/BEAM-7785?focusedWorklogId=282414&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-282414 ]
ASF GitHub Bot logged work on BEAM-7785: ---------------------------------------- Author: ASF GitHub Bot Created on: 25/Jul/19 03:20 Start Date: 25/Jul/19 03:20 Worklog Time Spent: 10m Work Description: kennknowles commented on issue #9108: [BEAM-7785] synchronize watermark update with bundle processing URL: https://github.com/apache/beam/pull/9108#issuecomment-514879421 This caused a failure in an integration test. I expect it was a deadlock. Probably for situations like this you want to take a snapshot for the PTransform evaluator so it sees an unchanging view, but nothing locking. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 282414) Time Spent: 1h 50m (was: 1h 40m) > DirectRunner: watermarks are updated asynchronously from bundle processing > -------------------------------------------------------------------------- > > Key: BEAM-7785 > URL: https://issues.apache.org/jira/browse/BEAM-7785 > Project: Beam > Issue Type: Bug > Components: runner-direct > Affects Versions: 2.13.0 > Reporter: Jan Lukavský > Assignee: Jan Lukavský > Priority: Major > Fix For: 2.15.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > Watermarks are updated in QuiescenceDriver (by calling fireTimers, which > calls forceRefresh()) on WatermarkManager. This results in creating timer > bundles, that are then processed asynchronously as DirectTransformExecutor. > Because of that, watermarks (input watermarks mostly) might be updated while > bundle is being processed. That violates assumption, that bundle processing > should be atomical (with identical external conditions during processing of > whole bundle). -- This message was sent by Atlassian JIRA (v7.6.14#76016)