[
https://issues.apache.org/jira/browse/BEAM-7607?focusedWorklogId=287052&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-287052
]
ASF GitHub Bot logged work on BEAM-7607:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Aug/19 21:30
Start Date: 01/Aug/19 21:30
Worklog Time Spent: 10m
Work Description: chamikaramj commented on pull request #9160:
[BEAM-7607] Per user request, making maxFilesPerBundle public
URL: https://github.com/apache/beam/pull/9160#discussion_r309905188
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java
##########
@@ -2019,8 +2019,7 @@ static String getExtractDestinationUri(String
extractDestinationDir) {
return toBuilder().setBigQueryServices(testServices).build();
}
- @VisibleForTesting
- Write<T> withMaxFilesPerBundle(int maxFilesPerBundle) {
+ public Write<T> withMaxFilesPerBundle(int maxFilesPerBundle) {
Review comment:
Can you please document the usage of this function ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 287052)
Time Spent: 50m (was: 40m)
> Expose withMaxFilesPerBundle in BigQuery IO public API
> ------------------------------------------------------
>
> Key: BEAM-7607
> URL: https://issues.apache.org/jira/browse/BEAM-7607
> Project: Beam
> Issue Type: Bug
> Components: io-java-gcp
> Reporter: Valentyn Tymofieiev
> Assignee: Pablo Estrada
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> MaxFilesPerBundle in Java BQ IO is visible for testing only [1], and some
> Beam users expressed interest in customizing that parameter, e.g. [2]. It is
> part of public API in BQ Python IO [3].
> cc: [~chamikara] [~pabloem] [~reuvenlax]
> https://github.com/apache/beam/blob/c775eda2df6457a784a1945d16cf781abb453d5f/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java#L1950
>
> [2] https://issues.apache.org/jira/browse/BEAM-2840
> [3]
> https://github.com/apache/beam/blob/c775eda2df6457a784a1945d16cf781abb453d5f/sdks/python/apache_beam/io/gcp/bigquery.py#L981
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
