[ 
https://issues.apache.org/jira/browse/BEAM-7829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16900175#comment-16900175
 ] 

Ryan Skraba commented on BEAM-7829:
-----------------------------------

The spark test suite for generating names and namespaces is here: 
https://github.com/apache/spark/blob/022667cea666190bea651a3873234700a472326c/external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala#L1239

If we use the same Avro naming strategy, we can be inspired from these.

> AvroUtils.toAvroSchema should put a Schema name to pass Avro Schema validation
> ------------------------------------------------------------------------------
>
>                 Key: BEAM-7829
>                 URL: https://issues.apache.org/jira/browse/BEAM-7829
>             Project: Beam
>          Issue Type: Test
>          Components: io-java-avro, sdk-java-core
>            Reporter: Ismaël Mejía
>            Assignee: Ryan Skraba
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> While trying to use an Avro PCollection with the SQL transform I notice you 
> could not do correctly a bijective transform: PCollection<GenericRecord> -> 
> SQL -> PCollection<Row> -> ParDo -> PCollection<GenericRecord> I noticed that 
> some of the Avro metadata gets lost in particular the name of the Avro 
> Schema. This is important because Avro validates that the schema has a name 
> and if it does not it breaks with a ParseException.
> {quote}
> org.apache.avro.SchemaParseException: Illegal character in: EXPR$1
>     at org.apache.avro.Schema.validateName (Schema.java:1151)
>     at org.apache.avro.Schema.access$200 (Schema.java:81)
>     at org.apache.avro.Schema$Field.<init> (Schema.java:403)
>     at org.apache.avro.Schema$Field.<init> (Schema.java:423)
>     at org.apache.avro.Schema$Field.<init> (Schema.java:415){quote}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to