[
https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=289078&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-289078
]
ASF GitHub Bot logged work on BEAM-5820:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Aug/19 17:38
Start Date: 05/Aug/19 17:38
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9189: [BEAM-5820]
[PoC] vendor calcite
URL: https://github.com/apache/beam/pull/9189#discussion_r310710894
##########
File path: sdks/java/extensions/sql/build.gradle
##########
@@ -29,33 +29,8 @@ applyJavaNature(
enableStrictDependencies: true,
shadowClosure: {
dependencies {
- include(dependency(library.java.guava))
- include(dependency(library.java.protobuf_java))
- include(dependency(library.java.protobuf_java_util))
- include(dependency("org.apache.calcite:.*"))
- include(dependency("org.apache.calcite.avatica:.*"))
- include(dependency("org.codehaus.janino:.*"))
+ include(dependency(library.java.vendored_calcite_1_19_0))
Review comment:
You wouldn't need to shade this dependency at all and could disable shading
within this gradle file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 289078)
Time Spent: 1h 10m (was: 1h)
> Vendor Calcite
> --------------
>
> Key: BEAM-5820
> URL: https://issues.apache.org/jira/browse/BEAM-5820
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
> Reporter: Kenneth Knowles
> Assignee: Kai Jiang
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
