[
https://issues.apache.org/jira/browse/BEAM-7738?focusedWorklogId=290208&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-290208
]
ASF GitHub Bot logged work on BEAM-7738:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Aug/19 04:23
Start Date: 07/Aug/19 04:23
Worklog Time Spent: 10m
Work Description: chadrik commented on pull request #9268: [BEAM-7738]
Add external transform support to PubSubIO
URL: https://github.com/apache/beam/pull/9268#discussion_r311363606
##########
File path: sdks/python/apache_beam/io/external/gcp/pubsub.py
##########
@@ -0,0 +1,131 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+from __future__ import absolute_import
+
+from apache_beam import ExternalTransform
+from apache_beam import pvalue
+from apache_beam.coders import BytesCoder
+from apache_beam.coders import FastPrimitivesCoder
+from apache_beam.coders.coders import LengthPrefixCoder
+from apache_beam.portability.api.external_transforms_pb2 import ConfigValue
+from apache_beam.portability.api.external_transforms_pb2 import
ExternalConfigurationPayload
+from apache_beam.transforms import ptransform
+
+
+class ReadFromPubSub(ptransform.PTransform):
+ """An external ``PTransform`` for reading from Cloud Pub/Sub."""
+
+ _urn = 'beam:external:java:pubsub:read:v1'
+
+ def __init__(self, topic=None, subscription=None, id_label=None,
+ with_attributes=False, timestamp_attribute=None,
+ expansion_service='localhost:8097'):
+ super(ReadFromPubSub, self).__init__()
+ self.topic = topic
+ self.subscription = subscription
+ self.id_label = id_label
+ self.with_attributes = with_attributes
+ self.timestamp_attribute = timestamp_attribute
+ self.expansion_service = expansion_service
+
+ def expand(self, pbegin):
+ if not isinstance(pbegin, pvalue.PBegin):
+ raise Exception("ReadFromPubSub must be a root transform")
+
+ args = {}
+
+ if self.topic is not None:
+ args['topic'] = _encode_str(self.topic)
+
+ if self.subscription is not None:
+ args['subscription'] = _encode_str(self.subscription)
+
+ if self.id_label is not None:
+ args['id_label'] = _encode_str(self.id_label)
+
+ # FIXME: how do we encode a bool so that Java can decode it?
+ # args['with_attributes'] = _encode_bool(self.with_attributes)
Review comment:
I encoded as int and handled the cast in java
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 290208)
Time Spent: 50m (was: 40m)
> Support PubSubIO to be configured externally for use with other SDKs
> --------------------------------------------------------------------
>
> Key: BEAM-7738
> URL: https://issues.apache.org/jira/browse/BEAM-7738
> Project: Beam
> Issue Type: New Feature
> Components: io-java-gcp, runner-flink, sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Labels: portability
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Now that KafkaIO is supported via the external transform API (BEAM-7029) we
> should add support for PubSub.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
