[
https://issues.apache.org/jira/browse/BEAM-7886?focusedWorklogId=294313&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294313
]
ASF GitHub Bot logged work on BEAM-7886:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Aug/19 01:11
Start Date: 14/Aug/19 01:11
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #9188:
[BEAM-7886] Make row coder a standard coder and implement in Python
URL: https://github.com/apache/beam/pull/9188#discussion_r313671666
##########
File path:
runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/CoderTranslationTest.java
##########
@@ -74,6 +78,14 @@
FullWindowedValueCoder.of(
IterableCoder.of(VarLongCoder.of()),
IntervalWindowCoder.of()))
.add(DoubleCoder.of())
+ .add(
Review comment:
Oh wow good catch! I've actually changed the coder translation now to create
instances of `PortableSchemaCoder`, which shouldn't have that problem. I also
reverted all the changes to RowCoder, so it's back to being a `CustomCoder`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 294313)
Time Spent: 2h 50m (was: 2h 40m)
> Make row coder a standard coder and implement in python
> -------------------------------------------------------
>
> Key: BEAM-7886
> URL: https://issues.apache.org/jira/browse/BEAM-7886
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, sdk-java-core, sdk-py-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
