[
https://issues.apache.org/jira/browse/BEAM-7969?focusedWorklogId=295015&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295015
]
ASF GitHub Bot logged work on BEAM-7969:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Aug/19 21:02
Start Date: 14/Aug/19 21:02
Worklog Time Spent: 10m
Work Description: angoenka commented on pull request #9330: [BEAM-7969]
Report FnAPI counters as deltas in streaming jobs.
URL: https://github.com/apache/beam/pull/9330#discussion_r314081113
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java
##########
@@ -1867,6 +1873,28 @@ private void sendWorkerUpdatesToDataflowService(
cumulativeCounters.extractUpdates(false,
DataflowCounterUpdateExtractor.INSTANCE));
counterUpdates.addAll(
deltaCounters.extractModifiedDeltaUpdates(DataflowCounterUpdateExtractor.INSTANCE));
+ if (hasExperiment(options, "beam_fn_api")) {
+ while (!this.pendingMonitoringInfos.isEmpty()) {
+ final CounterUpdate item = this.pendingMonitoringInfos.poll();
Review comment:
Lets also check for item == null to avoid possible race condition as its
called at start, via a timer and at stop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 295015)
Time Spent: 1h 20m (was: 1h 10m)
> Streaming Dataflow worker doesn't report FnAPI metrics.
> -------------------------------------------------------
>
> Key: BEAM-7969
> URL: https://issues.apache.org/jira/browse/BEAM-7969
> Project: Beam
> Issue Type: Bug
> Components: java-fn-execution, runner-dataflow
> Reporter: Mikhail Gryzykhin
> Assignee: Mikhail Gryzykhin
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> EOM
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
