[
https://issues.apache.org/jira/browse/BEAM-5428?focusedWorklogId=301107&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301107
]
ASF GitHub Bot logged work on BEAM-5428:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Aug/19 09:06
Start Date: 26/Aug/19 09:06
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #9418: [BEAM-5428][WIP]
State caching in the Python SDK
URL: https://github.com/apache/beam/pull/9418#discussion_r317513940
##########
File path: sdks/python/apache_beam/runners/worker/sdk_worker.py
##########
@@ -464,6 +469,7 @@ def __init__(self, credentials=None):
self._lock = threading.Lock()
self._throwing_state_handler = ThrowingStateHandler()
self._credentials = credentials
+ self.state_cache = StateCache(100)
Review comment:
This factory class is instantiated only once and shared by all the workers
in the SDK Harness. I prefer non-static variables because they make testing
easier and generally are less error-prone due to automatic cleanup when the
instance goes away.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 301107)
Time Spent: 4h 20m (was: 4h 10m)
> Implement cross-bundle state caching.
> -------------------------------------
>
> Key: BEAM-5428
> URL: https://issues.apache.org/jira/browse/BEAM-5428
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-harness
> Reporter: Robert Bradshaw
> Assignee: Rakesh Kumar
> Priority: Major
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> Tech spec:
> [https://docs.google.com/document/d/1BOozW0bzBuz4oHJEuZNDOHdzaV5Y56ix58Ozrqm2jFg/edit#heading=h.7ghoih5aig5m]
> Relevant document:
> [https://docs.google.com/document/d/1ltVqIW0XxUXI6grp17TgeyIybk3-nDF8a0-Nqw-s9mY/edit#|https://docs.google.com/document/d/1ltVqIW0XxUXI6grp17TgeyIybk3-nDF8a0-Nqw-s9mY/edit]
> Mailing list link:
> [https://lists.apache.org/thread.html/caa8d9bc6ca871d13de2c5e6ba07fdc76f85d26497d95d90893aa1f6@%3Cdev.beam.apache.org%3E]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
