[ https://issues.apache.org/jira/browse/BEAM-8032?focusedWorklogId=302973&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302973 ]
ASF GitHub Bot logged work on BEAM-8032: ---------------------------------------- Author: ASF GitHub Bot Created on: 28/Aug/19 15:44 Start Date: 28/Aug/19 15:44 Worklog Time Spent: 10m Work Description: charithe commented on issue #9425: [BEAM-8032] Fix JDBC readRows exception when statement preparator is null URL: https://github.com/apache/beam/pull/9425#issuecomment-525804007 I am not sure I follow your reasoning. Can you please elaborate? `StatementPreparator` _can_ be null. I missed that when writing the `ReadRows` class. The change I am suggesting now is very similar to the existing implementation in the `Read` class which handles the null `StatementPreparator` case: https://github.com/apache/beam/blob/7a2b847fc33a5b59275152dc1bd8014284aa4e27/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java#L646-L651 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 302973) Time Spent: 40m (was: 0.5h) > JdbcIO.readRows() throws exception when the statementPreparator is not > provided for simple Select statement > ----------------------------------------------------------------------------------------------------------- > > Key: BEAM-8032 > URL: https://issues.apache.org/jira/browse/BEAM-8032 > Project: Beam > Issue Type: Bug > Components: io-java-jdbc > Affects Versions: 2.14.0 > Reporter: Kishor Joshi > Assignee: Charith Ellawala > Priority: Major > Fix For: 2.16.0 > > Time Spent: 40m > Remaining Estimate: 0h > > I want to read table data with a query without parameters (select * from > table_name). > As per my understanding, this should not require "StatementPreperator". > However, if I use the newly added "readRows" function, I get an exception > that seems to force me to use the "StatementPreperator". > Stacktrace below. > > java.lang.IllegalArgumentException: statementPreparator can not be null > at > org.apache.beam.vendor.guava.v20_0.com.google.common.base.Preconditions.checkArgument(Preconditions.java:122) > at > org.apache.beam.sdk.io.jdbc.JdbcIO$Read.withStatementPreparator(JdbcIO.java:600) > at org.apache.beam.sdk.io.jdbc.JdbcIO$ReadRows.expand(JdbcIO.java:499) > at org.apache.beam.sdk.io.jdbc.JdbcIO$ReadRows.expand(JdbcIO.java:410) > at org.apache.beam.sdk.Pipeline.applyInternal(Pipeline.java:537) > at org.apache.beam.sdk.Pipeline.applyTransform(Pipeline.java:471) > at org.apache.beam.sdk.values.PBegin.apply(PBegin.java:44) > at > com.nokia.csf.dfle.transforms.DfleRdbmsSource.expand(DfleRdbmsSource.java:34) > at > com.nokia.csf.dfle.transforms.DfleRdbmsSource.expand(DfleRdbmsSource.java:10) > at org.apache.beam.sdk.Pipeline.applyInternal(Pipeline.java:537) > at org.apache.beam.sdk.Pipeline.applyTransform(Pipeline.java:488) > at org.apache.beam.sdk.values.PBegin.apply(PBegin.java:56) > at org.apache.beam.sdk.Pipeline.apply(Pipeline.java:182) -- This message was sent by Atlassian Jira (v8.3.2#803003)