[
https://issues.apache.org/jira/browse/BEAM-8113?focusedWorklogId=305549&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-305549
]
ASF GitHub Bot logged work on BEAM-8113:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Sep/19 11:43
Start Date: 03/Sep/19 11:43
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #9451: [BEAM-8113] Stage
files from context classloader
URL: https://github.com/apache/beam/pull/9451#discussion_r320169853
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkRunner.java
##########
@@ -76,8 +76,7 @@ public static FlinkRunner fromOptions(PipelineOptions
options) {
}
if (flinkOptions.getFilesToStage() == null) {
- flinkOptions.setFilesToStage(
- detectClassPathResourcesToStage(FlinkRunner.class.getClassLoader()));
+
flinkOptions.setFilesToStage(detectClassPathResourcesToStage(FlinkRunner.class));
Review comment:
This would stop at the FlinkRunner classloader, no? FlinkRunner is not part
of the Flink cluster and needs to be shipped.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 305549)
Time Spent: 5h 40m (was: 5.5h)
> FlinkRunner: Stage files from context classloader
> -------------------------------------------------
>
> Key: BEAM-8113
> URL: https://issues.apache.org/jira/browse/BEAM-8113
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Reporter: Jan Lukavský
> Assignee: Jan Lukavský
> Priority: Major
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
> Currently, only files from {{FlinkRunner.class.getClassLoader()}} are staged
> by default. Add also files from
> {{Thread.currentThread().getContextClassLoader()}}.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
