[
https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=310210&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-310210
]
ASF GitHub Bot logged work on BEAM-5820:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Sep/19 00:09
Start Date: 11/Sep/19 00:09
Worklog Time Spent: 10m
Work Description: vectorijk commented on pull request #9189: [BEAM-5820]
vendor calcite
URL: https://github.com/apache/beam/pull/9189#discussion_r323012683
##########
File path: sdks/java/extensions/sql/build.gradle
##########
@@ -22,48 +22,7 @@ plugins {
id 'org.apache.beam.module'
id 'ca.coglinc.javacc'
}
-applyJavaNature(
- // javacc generated code produces lint warnings
- disableLintWarnings: ['dep-ann'],
- testShadowJar: true,
- enableStrictDependencies: true,
- shadowClosure: {
- dependencies {
- include(dependency(library.java.guava))
- include(dependency(library.java.protobuf_java))
- include(dependency(library.java.protobuf_java_util))
- include(dependency("org.apache.calcite:.*"))
- include(dependency("org.apache.calcite.avatica:.*"))
- include(dependency("org.codehaus.janino:.*"))
- include(dependency("com.google.zetasql:.*"))
- }
- // guava uses the com.google.common and com.google.thirdparty package
namespaces
- relocate("com.google.common",
project.getJavaRelocatedPath("com.google.common")) {
- // com.google.common is too generic, need to exclude guava-testlib
- exclude "com.google.common.collect.testing.**"
- exclude "com.google.common.escape.testing.**"
- exclude "com.google.common.testing.**"
- exclude "com.google.common.util.concurrent.testing.**"
- }
- relocate "com.google.cloud", getJavaRelocatedPath("com.google.cloud")
- relocate "com.google.logging", getJavaRelocatedPath("com.google.logging")
- relocate "com.google.longrunning",
getJavaRelocatedPath("com.google.longrunning")
- relocate "com.google.rpc", getJavaRelocatedPath("com.google.rpc")
-
- relocate "com.google.thirdparty",
project.getJavaRelocatedPath("com.google.thirdparty")
-
- relocate "com.google.protobuf", getJavaRelocatedPath("com.google.protobuf")
- relocate "com.google.zetasql", getJavaRelocatedPath("com.google.zetasql")
- relocate "org.apache.calcite", getJavaRelocatedPath("org.apache.calcite")
-
- // Looking up the compiler factory in Calcite depends on having a properties
- // file in the right location. We package one that is shading compatible
- // in src/main/resources. Note that if this shaded path changes, that
- // files name and contents need to be updated as well. TODO, swap to use
- // getJavaRelocatedPath once the Maven build is no longer also shading this
- // module.
- relocate "org.codehaus",
"org.apache.beam.sdks.java.extensions.sql.repackaged.org.codehaus"
-})
+applyJavaNature( disableLintWarnings: ['dep-ann'] )
Review comment:
disable javacc generated code produces lint warnings
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 310210)
Time Spent: 7h 20m (was: 7h 10m)
> Vendor Calcite
> --------------
>
> Key: BEAM-5820
> URL: https://issues.apache.org/jira/browse/BEAM-5820
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
> Reporter: Kenneth Knowles
> Assignee: Kai Jiang
> Priority: Major
> Time Spent: 7h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
