[ https://issues.apache.org/jira/browse/BEAM-8111?focusedWorklogId=311200&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311200 ]
ASF GitHub Bot logged work on BEAM-8111: ---------------------------------------- Author: ASF GitHub Bot Created on: 12/Sep/19 06:18 Start Date: 12/Sep/19 06:18 Worklog Time Spent: 10m Work Description: kennknowles commented on pull request #9446: [BEAM-8111] Enable CloudObjectsTest$DefaultCoders URL: https://github.com/apache/beam/pull/9446#discussion_r323571191 ########## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaCoder.java ########## @@ -100,4 +99,47 @@ public boolean consistentWithEquals() { public String toString() { return "SchemaCoder: " + rowCoder.toString(); } + + @Override + public boolean equals(Object o) { + if (this == o) { + return true; + } + if (o == null || getClass() != o.getClass()) { + return false; + } + SchemaCoder<?> that = (SchemaCoder<?>) o; + return rowCoder.equals(that.rowCoder) + && toRowFunction.equals(that.toRowFunction) + && fromRowFunction.equals(that.fromRowFunction); Review comment: The way I would phrase this is: let the functions own their equals. If they say they are equal, they are. If they say they aren't, they aren't. So this equals() is relative to that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 311200) Time Spent: 3h 10m (was: 3h) > SchemaCoder broken on DataflowRunner > ------------------------------------ > > Key: BEAM-8111 > URL: https://issues.apache.org/jira/browse/BEAM-8111 > Project: Beam > Issue Type: Bug > Components: runner-dataflow, sdk-java-core > Affects Versions: 2.15.0 > Reporter: Brian Hulette > Assignee: Brian Hulette > Priority: Blocker > Fix For: 2.16.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > https://github.com/apache/beam/commit/e65c176a9f34e45d408281e1101a2ae54cef0f6c > broke SchemaCoder on Dataflow. When translating a schema that uses logical > types from a cloud object dataflow encounters a runtime error. > This means any pipelines that use SqlTransform or schema transforms will fail > on Dataflow in 2.15.0 -- This message was sent by Atlassian Jira (v8.3.2#803003)