[ 
https://issues.apache.org/jira/browse/BEAM-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16929378#comment-16929378
 ] 

Valentyn Tymofieiev commented on BEAM-8229:
-------------------------------------------

As Udi said, there aren't any Py3-only integration tests, as we run all ITs 
across Py2.7, 3.5-3.7.
We don't plan to keep our codebase Py2 compatible once we cut Beam 2.18.0, so 
py3-only exclusions won't be necessary in integration_test.sh in early 2020, 
however if at some time we will have a Python3.7 IT  that we don't want to run 
on Python 3.6, then we will need better exclusion mechanism for minor versions. 
At the moment Chad's proposal for extending regex SGTM. 

> Python postcommit 2.7 tests are failing since we try to run a test with 
> Python 3.6+ syntax on Python 2.
> -------------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-8229
>                 URL: https://issues.apache.org/jira/browse/BEAM-8229
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Ahmet Altay
>            Assignee: Udi Meiri
>            Priority: Blocker
>
> Root cause: https://github.com/apache/beam/pull/9098
> 20:12:14 Traceback (most recent call last):
> 20:12:14   File 
> "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python2_PR/src/build/gradleenv/-194514014/local/lib/python2.7/site-packages/nose/loader.py",
>  line 418, in loadTestsFromName
> 20:12:14     addr.filename, addr.module)
> 20:12:14   File 
> "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python2_PR/src/build/gradleenv/-194514014/local/lib/python2.7/site-packages/nose/importer.py",
>  line 47, in importFromPath
> 20:12:14     return self.importFromDir(dir_path, fqname)
> 20:12:14   File 
> "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python2_PR/src/build/gradleenv/-194514014/local/lib/python2.7/site-packages/nose/importer.py",
>  line 94, in importFromDir
> 20:12:14     mod = load_module(part_fqname, fh, filename, desc)
> 20:12:14 SyntaxError: invalid syntax (external_test_py37.py, line 46)



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to