[ 
https://issues.apache.org/jira/browse/BEAM-7049?focusedWorklogId=312302&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312302
 ]

ASF GitHub Bot logged work on BEAM-7049:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Sep/19 20:03
            Start Date: 13/Sep/19 20:03
    Worklog Time Spent: 10m 
      Work Description: amaliujia commented on pull request #9358: 
(WIP-BEAM-7049)Changes made to make a simple case of threeway union work
URL: https://github.com/apache/beam/pull/9358#discussion_r324347562
 
 

 ##########
 File path: 
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/planner/BeamRuleSets.java
 ##########
 @@ -141,6 +142,7 @@
 
   private static final List<RelOptRule> BEAM_CONVERTERS =
       ImmutableList.of(
+          UnionMergeRule.INSTANCE, //Added for three way union
 
 Review comment:
   If it still does not work, you could 
   1. re-clone a new repo of Beam
   2. add UnionMergeRule
   3. change `BeamCostModel.FACTORY` to `null` at 
https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/CalciteQueryPlanner.java#L116
   
   
   
   Then quickly test 
   ```
   SELECT 1
   UNION ALL
   SELECT 2
   UNION ALL
   SELECT 3
   UNION ALL
   SELECT 4
   UNION ALL
   SELECT 5
   ```
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 312302)
    Time Spent: 1h  (was: 50m)

> Merge multiple input to one BeamUnionRel
> ----------------------------------------
>
>                 Key: BEAM-7049
>                 URL: https://issues.apache.org/jira/browse/BEAM-7049
>             Project: Beam
>          Issue Type: Improvement
>          Components: dsl-sql
>            Reporter: Rui Wang
>            Assignee: sridhar Reddy
>            Priority: Major
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> BeamUnionRel assumes inputs are two and rejects more. So `a UNION b UNION c` 
> will have to be created as UNION(a, UNION(b, c)) and have two shuffles. If 
> BeamUnionRel can handle multiple shuffles, we will have only one shuffle



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to