[
https://issues.apache.org/jira/browse/BEAM-8224?focusedWorklogId=313301&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-313301
]
ASF GitHub Bot logged work on BEAM-8224:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Sep/19 21:22
Start Date: 16/Sep/19 21:22
Worklog Time Spent: 10m
Work Description: aaltay commented on issue #9563: [BEAM-8224] Fix bug in
_fn_takes_side_inputs
URL: https://github.com/apache/beam/pull/9563#issuecomment-531963674
> trivial_inference.py defaults to Any in 3.6, 3.7 since it doesn't support
kwargs (added by the wrapper).
> In 2.7, 3.5 these are supported, but since side-input hints are not passed
along the inferred output type is str, and the coder for that fails to encode a
tuple.
>
> Even if we did pass side-input hints, there is still missing logic that
would bind the arguments for the var_positional into a single tuple (like
getcallargs or signature.bind).
>
> Perhaps we should skip trivial_inference when side-inputs are present.
Would we need to skip it for all python version or for some python versions?
I am in favor of skipping in order to not block the release and continue
with the proper fix in master.
/cc @tvalentyn in case anything needs to be documented as known issues for
python 3.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 313301)
Time Spent: 2h 50m (was: 2h 40m)
> The way we inspect arguments in Python does not work for lambda *_: ...
> -----------------------------------------------------------------------
>
> Key: BEAM-8224
> URL: https://issues.apache.org/jira/browse/BEAM-8224
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Yueyang Qiu
> Assignee: Udi Meiri
> Priority: Blocker
> Fix For: 2.16.0
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> We need to make it work and create a test for this case.
>
> Assigning to Udi who authored
> [https://github.com/apache/beam/pull/9283|https://www.google.com/url?q=https://github.com/apache/beam/pull/9283&sa=D&usg=AFQjCNETtLzhe9jPfGzLHJb2N4Sle-FuNw].
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
