[
https://issues.apache.org/jira/browse/BEAM-5428?focusedWorklogId=318497&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318497
]
ASF GitHub Bot logged work on BEAM-5428:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Sep/19 18:09
Start Date: 25/Sep/19 18:09
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #9374: [BEAM-5428]
Implement Runner support for cache tokens
URL: https://github.com/apache/beam/pull/9374#discussion_r328266675
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/state/StateRequestHandlers.java
##########
@@ -414,6 +432,21 @@ public static StateRequestHandler
forBagUserStateHandlerFactory(
}
}
+ @Override
+ public Iterable<BeamFnApi.ProcessBundleRequest.CacheToken>
getCacheTokens() {
+ return handlerCache.values().stream()
Review comment:
It depends what you are used to. I find the fluent pattern easier to read,
but I agree that the procedural definition is probably easier for most people.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 318497)
Time Spent: 21h 20m (was: 21h 10m)
> Implement cross-bundle state caching.
> -------------------------------------
>
> Key: BEAM-5428
> URL: https://issues.apache.org/jira/browse/BEAM-5428
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-harness
> Reporter: Robert Bradshaw
> Assignee: Maximilian Michels
> Priority: Major
> Time Spent: 21h 20m
> Remaining Estimate: 0h
>
> Tech spec:
> [https://docs.google.com/document/d/1BOozW0bzBuz4oHJEuZNDOHdzaV5Y56ix58Ozrqm2jFg/edit#heading=h.7ghoih5aig5m]
> Relevant document:
> [https://docs.google.com/document/d/1ltVqIW0XxUXI6grp17TgeyIybk3-nDF8a0-Nqw-s9mY/edit#|https://docs.google.com/document/d/1ltVqIW0XxUXI6grp17TgeyIybk3-nDF8a0-Nqw-s9mY/edit]
> Mailing list link:
> [https://lists.apache.org/thread.html/caa8d9bc6ca871d13de2c5e6ba07fdc76f85d26497d95d90893aa1f6@%3Cdev.beam.apache.org%3E]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
