[
https://issues.apache.org/jira/browse/BEAM-8275?focusedWorklogId=319255&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319255
]
ASF GitHub Bot logged work on BEAM-8275:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Sep/19 22:13
Start Date: 26/Sep/19 22:13
Worklog Time Spent: 10m
Work Description: apilloud commented on pull request #9625: [BEAM-8275]
Beam SQL should support BigQuery in DIRECT_READ mode
URL: https://github.com/apache/beam/pull/9625#discussion_r326830964
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/bigquery/BigQueryTable.java
##########
@@ -45,15 +49,45 @@
*/
@Experimental
class BigQueryTable extends BaseBeamTable implements Serializable {
+ @VisibleForTesting static final String METHOD_PROPERTY = "method";
@VisibleForTesting final String bqLocation;
private final ConversionOptions conversionOptions;
private BeamTableStatistics rowCountStatistics = null;
private static final Logger LOGGER =
LoggerFactory.getLogger(BigQueryTable.class);
+ @VisibleForTesting Method method;
Review comment:
This is set exactly once (per code path) in the constructor, so you should
be able to make it `final`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 319255)
Time Spent: 1h 10m (was: 1h)
> Beam SQL should support BigQuery in DIRECT_READ mode
> ----------------------------------------------------
>
> Key: BEAM-8275
> URL: https://issues.apache.org/jira/browse/BEAM-8275
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Andrew Pilloud
> Assignee: Kirill Kozlov
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> SQL currently only supports reading from BigQuery in DEFAULT (EXPORT) mode.
> We also need to support DIRECT_READ mode. The method should be configurable
> by TBLPROPERTIES through the SQL CLI. This will enable us to take advantage
> of the DIRECT_READ features for filter and project push down.
> References:
> [https://beam.apache.org/documentation/io/built-in/google-bigquery/#storage-api]
> [https://beam.apache.org/blog/2019/06/04/adding-data-sources-to-sql.html]
> [https://github.com/apache/beam/blob/c2f0d282337f3ae0196a7717712396a5a41fdde1/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/bigquery/BigQueryTable.java]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
