[
https://issues.apache.org/jira/browse/BEAM-8162?focusedWorklogId=319494&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319494
]
ASF GitHub Bot logged work on BEAM-8162:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Sep/19 11:32
Start Date: 27/Sep/19 11:32
Worklog Time Spent: 10m
Work Description: mxm commented on issue #9464: [BEAM-8162] Encode keys
as NESTED for flink keyselector
URL: https://github.com/apache/beam/pull/9464#issuecomment-535902308
I very much appreciate your work on this @sunjincheng121. Let it be said,
your contributions are recognized. I also have to repeat that your solution in
this PR was incomplete. Not only did it not adhere to our contribution standard
because it was originally without a JIRA ("hotfix"), but it was also missing
the Python part which would have broken the Python support, as our tests
showed. It required careful investigation to find out the root of the problem
and to not break any other SDK as the result of a quick fix. We could not
iterate on your PR because it was already merged, so reverting it was the only
option.
I know that getting one's commit reverted is not a good feeling. It happens
to everyone eventually, and it is not to diminish your contributors in any way.
Keep up the great contributions. I know that everyone in the Beam community
greatly appreciates your work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 319494)
Time Spent: 1h 40m (was: 1.5h)
> NPE error when add flink 1.9 runner
> -----------------------------------
>
> Key: BEAM-8162
> URL: https://issues.apache.org/jira/browse/BEAM-8162
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: sunjincheng
> Assignee: sunjincheng
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> When add flink 1.9 runner in https://github.com/apache/beam/pull/9296, we
> find an NPE error when run the `PortableTimersExecutionTest`.
> the detail can be found here:
> https://github.com/apache/beam/pull/9296#issuecomment-525262607
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
