[ https://issues.apache.org/jira/browse/BEAM-8312?focusedWorklogId=321835&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-321835 ]
ASF GitHub Bot logged work on BEAM-8312: ---------------------------------------- Author: ASF GitHub Bot Created on: 02/Oct/19 11:53 Start Date: 02/Oct/19 11:53 Worklog Time Spent: 10m Work Description: mxm commented on issue #9681: [BEAM-8312] ArtifactRetrievalService serving artifacts from jar. URL: https://github.com/apache/beam/pull/9681#issuecomment-537457713 You forgot the other failure: ``` 00:44:42 * What went wrong: 00:44:42 Execution failed for task ':runners:java-fn-execution:spotbugsMain'. 00:44:42 > SpotBugs rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Phrase/src/runners/java-fn-execution/build/reports/spotbugs/main.xml ``` Fix is here: #9710. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 321835) Time Spent: 3.5h (was: 3h 20m) > Flink portable pipeline jars do not need to stage artifacts remotely > -------------------------------------------------------------------- > > Key: BEAM-8312 > URL: https://issues.apache.org/jira/browse/BEAM-8312 > Project: Beam > Issue Type: Improvement > Components: runner-flink > Reporter: Kyle Weaver > Assignee: Kyle Weaver > Priority: Major > Labels: portability-flink > Time Spent: 3.5h > Remaining Estimate: 0h > > Currently, Flink job jars re-stage all artifacts at runtime (on the > JobManager) by using the usual BeamFileSystemArtifactRetrievalService [1]. > However, since the manifest and all the artifacts live on the classpath of > the jar, and everything from the classpath is copied to the Flink workers > anyway [2], it should not be necessary to do additional artifact staging. We > could replace BeamFileSystemArtifactRetrievalService in this case with a > simple ArtifactRetrievalService that just pulls the artifacts from the > classpath. > > [1] > [https://github.com/apache/beam/blob/340c3202b1e5824b959f5f9f626e4c7c7842a3cb/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/artifact/BeamFileSystemArtifactRetrievalService.java] > [2] > [https://github.com/apache/beam/blob/2f1b56ccc506054e40afe4793a8b556e872e1865/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkExecutionEnvironments.java#L93] -- This message was sent by Atlassian Jira (v8.3.4#803005)