[
https://issues.apache.org/jira/browse/BEAM-8335?focusedWorklogId=323574&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323574
]
ASF GitHub Bot logged work on BEAM-8335:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Oct/19 17:01
Start Date: 04/Oct/19 17:01
Worklog Time Spent: 10m
Work Description: aaltay commented on pull request #9720: [BEAM-8335] Add
initial modules for interactive streaming support
URL: https://github.com/apache/beam/pull/9720#discussion_r331594849
##########
File path:
sdks/python/apache_beam/runners/interactive/caching/streaming_cache.py
##########
@@ -0,0 +1,123 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+from apache_beam.portability.api.beam_interactive_api_pb2 import
InteractiveStreamRecord
+from apache_beam.portability.api.beam_runner_api_pb2 import TestStreamPayload
+from apache_beam.utils import timestamp
+
+from google.protobuf import timestamp_pb2
+
+
+def to_timestamp(timestamp_secs):
+ """Converts seconds since epoch to an apache_beam.util.Timestamp.
+ """
+ return timestamp.Timestamp.of(timestamp_secs)
+
+def from_timestamp_proto(timestamp_proto):
+ return timestamp.Timestamp(seconds=timestamp_proto.seconds,
+ micros=timestamp_proto.nanos * 1000)
+
+def to_timestamp_usecs(ts):
+ """Converts a google.protobuf.Timestamp and
+ apache_beam.util.timestamp.Timestamp to seconds since epoch.
+ """
+ if isinstance(ts, timestamp_pb2.Timestamp):
+ return (ts.seconds * 10**6) + (ts.nanos * 10**-3)
+ if isinstance(ts, timestamp.Timestamp):
+ return ts.micros
+
+class StreamingCache(object):
+ """Abstraction that holds the logic for reading and writing to cache.
+ """
+ def __init__(self, readers):
+ self._readers = readers
+
+ class Reader(object):
+ """Abstraction that reads from PCollection readers.
+
+ This class is an Abstraction layer over multiple PCollection readers to be
+ used for supplying the Interactive Service with TestStream events.
+
+ This class is also responsible for holding the state of the clock,
injecting
+ clock advancement events, and watermark advancement events.
+ """
+ def __init__(self, readers):
+ self._readers = [reader.read() for reader in readers]
+ self._watermark = timestamp.MIN_TIMESTAMP
Review comment:
Should the default for watermark and timestamp be reflect something from the
`readers`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 323574)
> Add streaming support to Interactive Beam
> -----------------------------------------
>
> Key: BEAM-8335
> URL: https://issues.apache.org/jira/browse/BEAM-8335
> Project: Beam
> Issue Type: Improvement
> Components: runner-py-interactive
> Reporter: Sam Rohde
> Assignee: Sam Rohde
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> This issue tracks the work items to introduce streaming support to the
> Interactive Beam experience. This will allow users to:
> * Write and run a streaming job in IPython
> * Automatically cache records from unbounded sources
> * Add a replay experience that replays all cached records to simulate the
> original pipeline execution
> * Add controls to play/pause/stop/step individual elements from the cached
> records
> * Add ability to inspect/visualize unbounded PCollections
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
