[
https://issues.apache.org/jira/browse/BEAM-8365?focusedWorklogId=326470&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-326470
]
ASF GitHub Bot logged work on BEAM-8365:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Oct/19 17:30
Start Date: 10/Oct/19 17:30
Worklog Time Spent: 10m
Work Description: 11moon11 commented on issue #9743: [BEAM-8365] Project
push-down for test table provider
URL: https://github.com/apache/beam/pull/9743#issuecomment-540690358
> You probably want a few more test cases here:
>
> 1. Empty list.
> 2. All the columns.
> 3. Duplicate columns.
> 4. Invalid columns.
>
> Otherwise LGTM
Added tests for 1-3. Passing invalid columns beaks things and is hard to
test. A list of selected columns should be generated by the rule and passed to
the table provider via BeamIOSourceRel. It should never get into an invalid
state, where false column names are being extracted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 326470)
Time Spent: 1h 20m (was: 1h 10m)
> Add project push-down capability to IO APIs
> -------------------------------------------
>
> Key: BEAM-8365
> URL: https://issues.apache.org/jira/browse/BEAM-8365
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Kirill Kozlov
> Assignee: Kirill Kozlov
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> * InMemoryTable should implement a following method:
> {code:java}
> public PCollection<Row> buildIOReader(
> PBegin begin, BeamSqlTableFilter filters, List<String> fieldNames);{code}
> Which should return a `PCollection` with fields specified in `fieldNames`
> list.
> * Create a rule to push fields used by a Calc (in projects and in a
> condition) down into TestTable IO.
> * Updating that same Calc (from previous step) to have a proper input and
> output schemes, remove unused fields.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
