[
https://issues.apache.org/jira/browse/BEAM-8350?focusedWorklogId=327030&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-327030
]
ASF GitHub Bot logged work on BEAM-8350:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Oct/19 18:27
Start Date: 11/Oct/19 18:27
Worklog Time Spent: 10m
Work Description: aaltay commented on issue #9725: [BEAM-8350] Upgrade to
Pylint 2.4
URL: https://github.com/apache/beam/pull/9725#issuecomment-541173859
Re: Py 2 deprecation date - I am not making a statement here on when. My
argument was it has not happened yet, earliest it will happen in early 2020,
and I would like to keep py2 linting support as long as py2 is supported in the
codebase.
I understand your argument. Is the following correct for this change:
- All py2 syntax errors will still be caught.
- There might be linting issues specific to py2 linter that might be missed
but that is not harmful.
I guess for linting we need a target version in mind. We cannot potentially
lint the same code base for different python versions with different rules.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 327030)
Time Spent: 3.5h (was: 3h 20m)
> Upgrade to pylint 2.4
> ---------------------
>
> Key: BEAM-8350
> URL: https://issues.apache.org/jira/browse/BEAM-8350
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> pylint 2.4 provides a number of new features and fixes, but the most
> important/pressing one for me is that 2.4 adds support for understanding
> python type annotations, which fixes a bunch of spurious unused import errors
> in the PR I'm working on for BEAM-7746.
> As of 2.0, pylint dropped support for running tests in python2, so to make
> the upgrade we have to move our lint jobs to python3. Doing so will put
> pylint into "python3-mode" and there is not an option to run in
> python2-compatible mode. That said, the beam code is intended to be python3
> compatible, so in practice, performing a python3 lint on the Beam code-base
> is perfectly safe. The primary risk of doing this is that someone introduces
> a python-3 only change that breaks python2, but these would largely be syntax
> errors that would be immediately caught by the unit and integration tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
