[
https://issues.apache.org/jira/browse/BEAM-8350?focusedWorklogId=328716&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-328716
]
ASF GitHub Bot logged work on BEAM-8350:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Oct/19 18:10
Start Date: 15/Oct/19 18:10
Worklog Time Spent: 10m
Work Description: tvalentyn commented on issue #9725: [BEAM-8350] Upgrade
to Pylint 2.4
URL: https://github.com/apache/beam/pull/9725#issuecomment-542337427
I went over the warnings, my suggestions below.
Fix in this PR (most changes affect one file):
- expression-not-assigned (recent test, can be fixed via _ = ...)
- singleton-comparison
- comparisons-with-literal
Exclude inline:
- using-constant-test - I don't get this warning. Consider excluding in-line
+ file a linter bug.
- comparison-with-callable - potentially useful, let's fix inline in 2
places.
Fix in a separate PR:
- invalid-overridden-method - I think this is worth fixing, we can file a
Jira + a make separate PR to be safe. I think AI here is to replace deprecated
decorator @abc.abstractproperty in filesystemio.py.
Exclude from lint (seem debatable/harmless) code style warnings:
- no-else-break
- unnecessary-pass
- consider-using-in
- try-except-raise
Exclude but add a newbie task 1 (may help somebody learn bits of python):
- consider-using-set-comprehension
- chained-comparison
- consider-using-sys-exit
Exclude but add a newbie task 2:
- unnecessary-comprehension. We should mention that in some places we should
use list (some_iter), in some just remove the comprehension. May be better to
do this in a separate task to avoid a blind approval during review as some
place need to be fixed differently.
Not sure. Let's exclude for now:
- stop-iteration-return.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 328716)
Time Spent: 6h 50m (was: 6h 40m)
> Upgrade to pylint 2.4
> ---------------------
>
> Key: BEAM-8350
> URL: https://issues.apache.org/jira/browse/BEAM-8350
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 6h 50m
> Remaining Estimate: 0h
>
> pylint 2.4 provides a number of new features and fixes, but the most
> important/pressing one for me is that 2.4 adds support for understanding
> python type annotations, which fixes a bunch of spurious unused import errors
> in the PR I'm working on for BEAM-7746.
> As of 2.0, pylint dropped support for running tests in python2, so to make
> the upgrade we have to move our lint jobs to python3. Doing so will put
> pylint into "python3-mode" and there is not an option to run in
> python2-compatible mode. That said, the beam code is intended to be python3
> compatible, so in practice, performing a python3 lint on the Beam code-base
> is perfectly safe. The primary risk of doing this is that someone introduces
> a python-3 only change that breaks python2, but these would largely be syntax
> errors that would be immediately caught by the unit and integration tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
