[ https://issues.apache.org/jira/browse/BEAM-8374?focusedWorklogId=330265&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-330265 ]
ASF GitHub Bot logged work on BEAM-8374: ---------------------------------------- Author: ASF GitHub Bot Created on: 18/Oct/19 04:11 Start Date: 18/Oct/19 04:11 Worklog Time Spent: 10m Work Description: cmachgodaddy commented on issue #9758: [BEAM-8374] Fixes bug in SnsIO PublishResultCoder URL: https://github.com/apache/beam/pull/9758#issuecomment-543489757 I wonder if we should add unit test for this coder? I know we did not have it, b/c we just had one property to encode and decode. But, now we have quite a few. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 330265) Time Spent: 1h 50m (was: 1h 40m) > PublishResult returned by SnsIO is missing sdkResponseMetadata and > sdkHttpMetadata > ---------------------------------------------------------------------------------- > > Key: BEAM-8374 > URL: https://issues.apache.org/jira/browse/BEAM-8374 > Project: Beam > Issue Type: Bug > Components: io-java-aws > Affects Versions: 2.13.0, 2.14.0, 2.15.0 > Reporter: Jonothan Farr > Assignee: Jonothan Farr > Priority: Minor > Time Spent: 1h 50m > Remaining Estimate: 0h > > Currently the PublishResultCoder in SnsIO only serializes the messageId field > so the PublishResult returned by Beam returns null for > getSdkResponseMetadata() and getSdkHttpMetadata(). This makes it impossible > to check the HTTP status for errors, which is necessary since this is not > handled in SnsIO. -- This message was sent by Atlassian Jira (v8.3.4#803005)