[ 
https://issues.apache.org/jira/browse/BEAM-8382?focusedWorklogId=331482&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-331482
 ]

ASF GitHub Bot logged work on BEAM-8382:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Oct/19 16:36
            Start Date: 21/Oct/19 16:36
    Worklog Time Spent: 10m 
      Work Description: cmachgodaddy commented on issue #9765: [BEAM-8382] Add 
polling interval to KinesisIO.Read
URL: https://github.com/apache/beam/pull/9765#issuecomment-544599853
 
 
   @aromanenko-dev , a bit technical, in KinesisSource, we have spit method, 
this method generate a number of sources or readers (or KinesisReader) ? This 
split method is now based on either the desiredNumSplits (which is configured 
by user as a parallelism parameter) or partitions (number of shards) to 
generate num of readers. However, in each reader (KinesisReader), we again 
generate another number of threads and each read one shard. So this looks to me 
a parallelism inside a parallelism (or nested parallelism). Here is in the 
KinesisReader, which call ShareReadersPool::start(), and which uses 
ExecutorService to execute 'readLoop' in parallel (in diff thread) 
https://github.com/apache/beam/blob/master/sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/ShardReadersPool.java#L124.
 Let me know if I am missing something?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 331482)
    Time Spent: 3h  (was: 2h 50m)

> Add polling interval to KinesisIO.Read
> --------------------------------------
>
>                 Key: BEAM-8382
>                 URL: https://issues.apache.org/jira/browse/BEAM-8382
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-kinesis
>    Affects Versions: 2.13.0, 2.14.0, 2.15.0
>            Reporter: Jonothan Farr
>            Assignee: Jonothan Farr
>            Priority: Major
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> With the current implementation we are observing Kinesis throttling due to 
> ReadProvisionedThroughputExceeded on the order of hundreds of times per 
> second, regardless of the actual Kinesis throughput. This is because the 
> ShardReadersPool readLoop() method is polling getRecords() as fast as 
> possible.
> From the KDS documentation:
> {quote}Each shard can support up to five read transactions per second.
> {quote}
> and
> {quote}For best results, sleep for at least 1 second (1,000 milliseconds) 
> between calls to getRecords to avoid exceeding the limit on getRecords 
> frequency.
> {quote}
> [https://docs.aws.amazon.com/streams/latest/dev/service-sizes-and-limits.html]
> [https://docs.aws.amazon.com/streams/latest/dev/developing-consumers-with-sdk.html]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to