[
https://issues.apache.org/jira/browse/BEAM-8405?focusedWorklogId=331579&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-331579
]
ASF GitHub Bot logged work on BEAM-8405:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Oct/19 18:54
Start Date: 21/Oct/19 18:54
Worklog Time Spent: 10m
Work Description: udim commented on issue #9805: [BEAM-8405] Support
embedded Datastore entities
URL: https://github.com/apache/beam/pull/9805#issuecomment-544656056
> LGTM other than one comment. Thanks.
>
> Do you think it's worth adding this to the IT ?
This should probably be tested but the existing IT only verifies counts of
entities, not actual content.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 331579)
Time Spent: 50m (was: 40m)
> Python: Datastore: add support for embedded entities
> -----------------------------------------------------
>
> Key: BEAM-8405
> URL: https://issues.apache.org/jira/browse/BEAM-8405
> Project: Beam
> Issue Type: Bug
> Components: io-py-gcp
> Reporter: Udi Meiri
> Assignee: Udi Meiri
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The conversion methods to/from the client entity type should be updated to
> support an embedded Entity.
> https://github.com/apache/beam/blob/603d68aafe9bdcd124d28ad62ad36af01e7a7403/sdks/python/apache_beam/io/gcp/datastore/v1new/types.py#L216-L240
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
