[
https://issues.apache.org/jira/browse/BEAM-7765?focusedWorklogId=332335&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-332335
]
ASF GitHub Bot logged work on BEAM-7765:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Oct/19 00:29
Start Date: 23/Oct/19 00:29
Worklog Time Spent: 10m
Work Description: pabloem commented on issue #9685: [BEAM-7765] - Add
test for snippet accessing_valueprovider_info_after_run
URL: https://github.com/apache/beam/pull/9685#issuecomment-545211504
Thanks for adding the snippets. There's only one more issue, with lints:
```
01:02:12 > Task :sdks:python:test-suites:tox:py2:lintPy27
01:02:12 ************* Module apache_beam.examples.snippets.snippets_test
01:02:12 C:1281, 0: Line too long (97/80) (line-too-long)
01:02:12 C:1306, 0: Wrong hanging indentation (add 7 spaces).
01:02:12 LogValueProvidersFn(my_options.string_value)))
01:02:12 ^ | (bad-continuation)
01:02:12 C:1315, 0: Line too long (87/80) (line-too-long)
01:02:12 C:1317, 0: Line too long (82/80) (line-too-long)
01:02:12 C:1318, 0: Trailing whitespace (trailing-whitespace)
01:02:12
01:02:12 --------------------------------------------------------------------
01:02:12 Your code has been rated at 10.00/10 (previous run: 10.00/10, -0.00)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 332335)
Time Spent: 2h 10m (was: 2h)
> Add test for snippet accessing_valueprovider_info_after_run
> -----------------------------------------------------------
>
> Key: BEAM-7765
> URL: https://issues.apache.org/jira/browse/BEAM-7765
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Udi Meiri
> Assignee: John Patoch
> Priority: Major
> Labels: easy
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> This snippet needs a unit test.
> It has bugs. For example:
> - apache_beam.utils.value_provider doesn't exist
> - beam.combiners.Sum doesn't exist
> - unused import of: WriteToText
> cc: [~pabloem]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
