[
https://issues.apache.org/jira/browse/BEAM-8398?focusedWorklogId=336262&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-336262
]
ASF GitHub Bot logged work on BEAM-8398:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Oct/19 16:31
Start Date: 30/Oct/19 16:31
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9792: [BEAM-8398]
Upgrade Dataflow Java Client API
URL: https://github.com/apache/beam/pull/9792#discussion_r340726421
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubJsonClient.java
##########
@@ -169,7 +169,7 @@ public int publish(TopicPath topic, List<OutgoingMessage>
outgoingMessages) thro
@Nullable Map<String, String> attributes = pubsubMessage.getAttributes();
// Payload.
- byte[] elementBytes = pubsubMessage.decodeData();
+ byte[] elementBytes = pubsubMessage.getData() == null ? null :
pubsubMessage.decodeData();
Review comment:
I downloaded the source for both versions
([1.27](https://repo1.maven.org/maven2/com/google/apis/google-api-services-pubsub/v1-rev20181105-1.27.0/google-api-services-pubsub-v1-rev20181105-1.27.0-sources.jar),
[1.28](https://repo1.maven.org/maven2/com/google/apis/google-api-services-pubsub/v1-rev20181213-1.28.0/google-api-services-pubsub-v1-rev20181213-1.28.0-sources.jar))
and they both invoke the Base64 library:
decodeData() uses com.google.api.client.util.Base64.decodeBase64
encodeData() uses com.google.api.client.util.Base64.encodeBase64URLSafeString
It looks like there was a change in the Base64 library implementation since
it now doesn't take null and return null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 336262)
Time Spent: 1h 40m (was: 1.5h)
> Upgrade Dataflow Java Client API
> --------------------------------
>
> Key: BEAM-8398
> URL: https://issues.apache.org/jira/browse/BEAM-8398
> Project: Beam
> Issue Type: Task
> Components: runner-dataflow
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
