[
https://issues.apache.org/jira/browse/BEAM-8568?focusedWorklogId=339828&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-339828
]
ASF GitHub Bot logged work on BEAM-8568:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Nov/19 09:55
Start Date: 07/Nov/19 09:55
Worklog Time Spent: 10m
Work Description: dmvk commented on pull request #10024: [BEAM-8568]
Fixed problem that LocalFileSystem no longer supports wil…
URL: https://github.com/apache/beam/pull/10024#discussion_r343561744
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/io/LocalFileSystemTest.java
##########
@@ -209,6 +209,30 @@ public void testMatchWithGlob() throws Exception {
containsInAnyOrder(expected.toArray(new String[expected.size()])));
}
+ @Test
+ public void testMatchInDirectoryRelativeWithGlob() throws Exception {
Review comment:
this test is copy pasted from `testMatchWithGlob`, can you move it to a
parametrized method, so the code can be reused?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 339828)
Time Spent: 0.5h (was: 20m)
> Local file system does not match relative path with wildcards
> -------------------------------------------------------------
>
> Key: BEAM-8568
> URL: https://issues.apache.org/jira/browse/BEAM-8568
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Affects Versions: 2.16.0
> Reporter: Ondrej Cerny
> Priority: Major
> Fix For: 2.17.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> CWD structure:
> {code}
> src/test/resources/input/sometestfile.txt
> {code}
>
> Code:
> {code:java}
> input
> .apply(Create.of("src/test/resources/input/*))
> .apply(FileIO.matchAll())
> .apply(FileIO.readMatches())
> {code}
> The code above doesn't match any file starting Beam 2.16.0. The regression
> has been introduced in BEAM-7854.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
