[ https://issues.apache.org/jira/browse/BEAM-8512?focusedWorklogId=339831&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-339831 ]
ASF GitHub Bot logged work on BEAM-8512: ---------------------------------------- Author: ASF GitHub Bot Created on: 07/Nov/19 09:57 Start Date: 07/Nov/19 09:57 Worklog Time Spent: 10m Work Description: mxm commented on pull request #9998: [BEAM-8512] Add integration tests for flink_runner.py URL: https://github.com/apache/beam/pull/9998#discussion_r343563448 ########## File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy ########## @@ -1953,8 +1953,10 @@ class BeamModulePlugin implements Plugin<Project> { } project.ext.addPortableWordCountTasks = { -> - addPortableWordCountTask(false) - addPortableWordCountTask(true) + addPortableWordCountTask(false, "PortableRunner") Review comment: Testing PortableRunner independently is important. Theoretically, the PortableRunner is a subset of FlinkRunner, but there are still things that can go wrong with the PortableRunner when it runs without the orchestration support of the FlinkRunner. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 339831) Time Spent: 1h 10m (was: 1h) > Add integration tests for Python "flink_runner.py" > -------------------------------------------------- > > Key: BEAM-8512 > URL: https://issues.apache.org/jira/browse/BEAM-8512 > Project: Beam > Issue Type: Test > Components: runner-flink, sdk-py-core > Reporter: Maximilian Michels > Assignee: Kyle Weaver > Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > There are currently no integration tests for the Python FlinkRunner. We need > a set of tests similar to {{flink_runner_test.py}} which currently use the > PortableRunner and not the FlinkRunner. > CC [~robertwb] [~ibzib] [~thw] -- This message was sent by Atlassian Jira (v8.3.4#803005)