[
https://issues.apache.org/jira/browse/BEAM-8457?focusedWorklogId=340125&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-340125
]
ASF GitHub Bot logged work on BEAM-8457:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Nov/19 20:03
Start Date: 07/Nov/19 20:03
Worklog Time Spent: 10m
Work Description: KevinGG commented on pull request #9885: [BEAM-8457]
Label Dataflow jobs from Notebook
URL: https://github.com/apache/beam/pull/9885#discussion_r343848058
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -360,6 +360,16 @@ def visit_transform(self, transform_node):
def run_pipeline(self, pipeline, options):
"""Remotely executes entire pipeline or parts reachable from node."""
+ # Label goog-dataflow-notebook if pipeline is initiated from interactive
+ # runner.
+ if pipeline.interactive:
Review comment:
Discussed with David and Sam. Since we also want to track jobs started from
notebook even if the user never uses `InteractiveRunner`, checking the
environment might just be the only way to do it.
By putting the logic into a try-except block as it is, we could avoid
introducing `ipython` dependency into `DataflowRunner`. If the `[interactive]`
dependency is never installed and current execution_path has never imported
`ipython`, the code would just never be executed.
I'll move the logic into a standalone utility module and import it in
DataflowRunner to do the check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 340125)
Time Spent: 8.5h (was: 8h 20m)
> Instrument Dataflow jobs that are launched from Notebooks
> ---------------------------------------------------------
>
> Key: BEAM-8457
> URL: https://issues.apache.org/jira/browse/BEAM-8457
> Project: Beam
> Issue Type: Improvement
> Components: runner-py-interactive
> Reporter: Ning Kang
> Assignee: Ning Kang
> Priority: Major
> Fix For: 2.17.0
>
> Time Spent: 8.5h
> Remaining Estimate: 0h
>
> Dataflow needs the capability to tell how many Dataflow jobs are launched
> from the Notebook environment, i.e., the Interactive Runner.
> # Change the pipeline.run() API to allow supply a runner and an option
> parameter so that a pipeline initially bundled w/ an interactive runner can
> be directly run by other runners from notebook.
> # Implicitly add the necessary source information through user labels when
> the user does p.run(runner=DataflowRunner()).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
