[
https://issues.apache.org/jira/browse/BEAM-8594?focusedWorklogId=340421&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-340421
]
ASF GitHub Bot logged work on BEAM-8594:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Nov/19 10:17
Start Date: 08/Nov/19 10:17
Worklog Time Spent: 10m
Work Description: sunjincheng121 commented on issue #10039: [BEAM-8594]
Remove unnecessary error check in DataFlow Runner
URL: https://github.com/apache/beam/pull/10039#issuecomment-551519388
R @lukecwik I am appreciate if you can review this changes :) Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 340421)
Time Spent: 20m (was: 10m)
> Remove unnecessary error check of the control service accessing in DataFlow
> Runner
> ----------------------------------------------------------------------------------
>
> Key: BEAM-8594
> URL: https://issues.apache.org/jira/browse/BEAM-8594
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: sunjincheng
> Assignee: sunjincheng
> Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently there are a few places in the DataFlow Runner which checks if there
> is error reported when accessing the SDK harness's control service. Actually,
> the error reported by the SDK harness has already been handled in the
> [FnApiControlClient|https://github.com/apache/beam/blob/c2f0d282337f3ae0196a7717712396a5a41fdde1/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/FnApiControlClient.java#L152].
> There is no need to check it anymore.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
