[
https://issues.apache.org/jira/browse/BEAM-8657?focusedWorklogId=343921&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-343921
]
ASF GitHub Bot logged work on BEAM-8657:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Nov/19 01:06
Start Date: 15/Nov/19 01:06
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #10098: [BEAM-8657]
Avoid lifting combiners for incompatible triggers.
URL: https://github.com/apache/beam/pull/10098
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 343921)
Time Spent: 1h 20m (was: 1h 10m)
> Not doing Combiner lifting for data-driven triggers
> ---------------------------------------------------
>
> Key: BEAM-8657
> URL: https://issues.apache.org/jira/browse/BEAM-8657
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: wendy liu
> Assignee: Robert Bradshaw
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The test below will always produce empty output, due to combiner lifting,
> which already combines all input values of one shard into one before
> grouping. To fix this, we shall not do Combiner lifting for the data-driven
> triggers.
> l = [window.TimestampedValue(('a', 1), 1),
> window.TimestampedValue(('b', 3), 3),
> window.TimestampedValue(('a', 2), 2),
> window.TimestampedValue(('a', 5), 5),]
> result = (p | Map(lambda x : x) | 'window' >>
> beam.WindowInto(FixedWindows(6), trigger=trigger.AfterCount(2),
> accumulation_mode=trigger.AccumulationMode.DISCARDING) |
> beam.CombinePerKey(combine.Largest(1)))
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
