[
https://issues.apache.org/jira/browse/BEAM-8592?focusedWorklogId=343989&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-343989
]
ASF GitHub Bot logged work on BEAM-8592:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Nov/19 05:14
Start Date: 15/Nov/19 05:14
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #10021: [BEAM-8592]
Adjusting ZetaSQL table resolution to standard
URL: https://github.com/apache/beam/pull/10021#issuecomment-554215720
Ah. Now that I have looked closer, these tests were running against
`ReadOnlyTableProvider` which does not support real table resolution. So it
used join components to just create a string for lookup.
Since ZetaSQL table reference (list of strings) is the same structure as a
Calcite table reference (list of strings), the main thing that is helpful is
just unit testing of the one real method of `TableResolution`. The only real
logic there is doing a `for` loop over that list of strings. I will write a
couple of tests for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 343989)
Time Spent: 1h (was: 50m)
> DataCatalogTableProvider should not squash table components together into a
> string
> ----------------------------------------------------------------------------------
>
> Key: BEAM-8592
> URL: https://issues.apache.org/jira/browse/BEAM-8592
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql, dsl-sql-zetasql
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Currently, if a user writes a table name like \{{foo.`baz.bar`.bizzle}}
> representing the components \{{"foo", "baz.bar", "bizzle"}} the
> DataCatalogTableProvider will concatenate the components into a string and
> resolve the identifier as if it represented \{{"foo", "baz", "bar",
> "bizzle"}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
