[ https://issues.apache.org/jira/browse/BEAM-8655?focusedWorklogId=344383&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-344383 ]
ASF GitHub Bot logged work on BEAM-8655: ---------------------------------------- Author: ASF GitHub Bot Created on: 15/Nov/19 16:22 Start Date: 15/Nov/19 16:22 Worklog Time Spent: 10m Work Description: robertwb commented on pull request #10096: [BEAM-8655] Strengthen trigger transcript tests. URL: https://github.com/apache/beam/pull/10096#discussion_r346903345 ########## File path: sdks/python/apache_beam/transforms/trigger_test.py ########## @@ -850,6 +873,16 @@ def diff(actual, expected): | beam.Flatten() | beam.ParDo(Check(self.allow_out_of_order))) + with TestPipeline() as p: + # TODO(BEAM-8601): Pass this during pipeline construction. + p.options.view_as(StandardOptions).streaming = True + + # We can have at most one test stream per pipeline, so we share it. + inputs_and_expected = p | read_test_stream + inputs_and_expected | CheckAggregation(beam.GroupByKey()) + inputs_and_expected | CheckAggregation(beam.CombinePerKey( Review comment: Yes. I've rebased it on top of that change that just went in. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 344383) Time Spent: 1h (was: 50m) > Strengthen trigger transcript tests > ----------------------------------- > > Key: BEAM-8655 > URL: https://issues.apache.org/jira/browse/BEAM-8655 > Project: Beam > Issue Type: Bug > Components: testing > Reporter: Robert Bradshaw > Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > We should run them with multiple keys, using combiners as well as > group-by-key, and when possible in batch mode. -- This message was sent by Atlassian Jira (v8.3.4#803005)