[ https://issues.apache.org/jira/browse/BEAM-8645?focusedWorklogId=344476&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-344476 ]
ASF GitHub Bot logged work on BEAM-8645: ---------------------------------------- Author: ASF GitHub Bot Created on: 15/Nov/19 18:44 Start Date: 15/Nov/19 18:44 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #10081: [BEAM-8645] A test case for TimestampCombiner. URL: https://github.com/apache/beam/pull/10081#issuecomment-554480944 Hi, Robert, I synced with your fixing PR for combiner lifting, now LATEST works (I removed skip tag), but EARLIEST still not correct. Maybe let us merge this test case, and then you can test against your up-coming PR easier. WDYT? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 344476) Time Spent: 1h 10m (was: 1h) > TimestampCombiner incorrect in beam python > ------------------------------------------ > > Key: BEAM-8645 > URL: https://issues.apache.org/jira/browse/BEAM-8645 > Project: Beam > Issue Type: Bug > Components: sdk-py-core > Reporter: Ruoyun Huang > Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > When we have a TimestampValue on combine: > {code:java} > main_stream = (p > | 'main TestStream' >> TestStream() > .add_elements([window.TimestampedValue(('k', 100), 0)]) > .add_elements([window.TimestampedValue(('k', 400), 9)]) > .advance_watermark_to_infinity() > | 'main windowInto' >> beam.WindowInto( > window.FixedWindows(10), > timestamp_combiner=TimestampCombiner.OUTPUT_AT_LATEST) | > 'Combine' >> beam.CombinePerKey(sum)) > The expect timestamp should be: > LATEST: (('k', 500), Timestamp(9)), > EARLIEST: (('k', 500), Timestamp(0)), > END_OF_WINDOW: (('k', 500), Timestamp(10)), > But current py streaming gives following results: > LATEST: (('k', 500), Timestamp(10)), > EARLIEST: (('k', 500), Timestamp(10)), > END_OF_WINDOW: (('k', 500), Timestamp(9.99999999)), > More details and discussions: > https://lists.apache.org/thread.html/d3af1f2f84a2e59a747196039eae77812b78a991f0f293c717e5f4e1@%3Cdev.beam.apache.org%3E > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)