[ https://issues.apache.org/jira/browse/BEAM-8335?focusedWorklogId=345461&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-345461 ]
ASF GitHub Bot logged work on BEAM-8335: ---------------------------------------- Author: ASF GitHub Bot Created on: 18/Nov/19 17:54 Start Date: 18/Nov/19 17:54 Worklog Time Spent: 10m Work Description: rohdesamuel commented on pull request #9953: DO NOT MERGE [BEAM-8335] Adds support for multi-output TestStream URL: https://github.com/apache/beam/pull/9953#discussion_r347523200 ########## File path: sdks/python/apache_beam/testing/test_stream.py ########## @@ -163,45 +167,71 @@ class TestStream(PTransform): """Test stream that generates events on an unbounded PCollection of elements. Each event emits elements, advances the watermark or advances the processing - time. After all of the specified elements are emitted, ceases to produce + time. After all of the specified elements are emitted, ceases to produce output. """ def __init__(self, coder=coders.FastPrimitivesCoder(), events=()): super(TestStream, self).__init__() assert coder is not None self.coder = coder - self.current_watermark = timestamp.MIN_TIMESTAMP - self.events = list(events) + self.watermarks = {None: timestamp.MIN_TIMESTAMP} + self._events = list(events) + self.output_tags = set() def get_windowing(self, unused_inputs): return core.Windowing(window.GlobalWindows()) def expand(self, pbegin): assert isinstance(pbegin, pvalue.PBegin) self.pipeline = pbegin.pipeline - return pvalue.PCollection(self.pipeline, is_bounded=False) - def _infer_output_coder(self, input_type=None, input_coder=None): - return self.coder + # This multiplexing the multiple output PCollections. + def mux(event): + if event.tag: + yield pvalue.TaggedOutput(event.tag, event) + else: + yield event + mux_output = (pbegin + | _TestStream(self.output_tags, events=self._events) + | 'TestStream Multiplexer' >> beam.ParDo(mux).with_outputs()) Review comment: Nope! The DoOutputsTuple dynamically adds the outputs when you use the [ ] operator. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 345461) Time Spent: 31h 10m (was: 31h) > Add streaming support to Interactive Beam > ----------------------------------------- > > Key: BEAM-8335 > URL: https://issues.apache.org/jira/browse/BEAM-8335 > Project: Beam > Issue Type: Improvement > Components: runner-py-interactive > Reporter: Sam Rohde > Assignee: Sam Rohde > Priority: Major > Time Spent: 31h 10m > Remaining Estimate: 0h > > This issue tracks the work items to introduce streaming support to the > Interactive Beam experience. This will allow users to: > * Write and run a streaming job in IPython > * Automatically cache records from unbounded sources > * Add a replay experience that replays all cached records to simulate the > original pipeline execution > * Add controls to play/pause/stop/step individual elements from the cached > records > * Add ability to inspect/visualize unbounded PCollections -- This message was sent by Atlassian Jira (v8.3.4#803005)