[
https://issues.apache.org/jira/browse/BEAM-8016?focusedWorklogId=345736&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-345736
]
ASF GitHub Bot logged work on BEAM-8016:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Nov/19 01:02
Start Date: 19/Nov/19 01:02
Worklog Time Spent: 10m
Work Description: KevinGG commented on pull request #10132: [BEAM-8016]
Pipeline Graph
URL: https://github.com/apache/beam/pull/10132#discussion_r347686453
##########
File path: sdks/python/apache_beam/runners/interactive/pipeline_instrument.py
##########
@@ -314,10 +316,29 @@ def cache_key(self, pcoll):
cacheable['producer_version']))
return ''
+ def cacheable_var_by_pcoll_id(self, pcoll_id):
+ """Retrieves the variable name of a PCollection.
+
+ In source code, PCollection variables are defined in the user pipeline.
When
+ it's converted to the runner api representation, each PCollection
referenced
+ in the user pipeline is assigned a unique-within-pipeline pcoll_id. Given
+ such pcoll_id, retrieves the str variable name defined in user pipeline for
+ that referenced PCollection. If the PCollection is anonymous, return ''.
+ """
+ return self._cacheable_var_by_pcoll_id.get(pcoll_id, '')
+
def pin(pipeline, options=None):
- """Creates PipelineInstrument for a pipeline and its options with cache."""
+ """Creates PipelineInstrument for a pipeline and its options with cache.
+
+ This is the shorthand for doing 3 steps: 1) compute once for metadata of
given
+ runner pipeline and everything watched from user pipelines; 2) associate info
+ between runner pipeline and its corresponding user pipeline, eliminate data
Review comment:
Thanks, done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 345736)
Time Spent: 2h 40m (was: 2.5h)
> Render Beam Pipeline as DOT with Interactive Beam
> ---------------------------------------------------
>
> Key: BEAM-8016
> URL: https://issues.apache.org/jira/browse/BEAM-8016
> Project: Beam
> Issue Type: Improvement
> Components: runner-py-interactive
> Reporter: Ning Kang
> Assignee: Ning Kang
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> With work in https://issues.apache.org/jira/browse/BEAM-7760, Beam pipeline
> converted to DOT then rendered should mark user defined variables on edges.
> With work in https://issues.apache.org/jira/browse/BEAM-7926, it might be
> redundant or confusing to render arbitrary random sample PCollection data on
> edges.
> We'll also make sure edges in the graph corresponds to output -> input
> relationship in the user defined pipeline. Each edge is one output. If
> multiple down stream inputs take the same output, it should be rendered as
> one edge diverging into two instead of two edges.
> For advanced interactivity highlight where each execution highlights the part
> of the pipeline really executed from the original pipeline, we'll also
> provide the support in beta.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
