[ https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=346250&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-346250 ]
ASF GitHub Bot logged work on BEAM-7746: ---------------------------------------- Author: ASF GitHub Bot Created on: 19/Nov/19 21:06 Start Date: 19/Nov/19 21:06 Worklog Time Spent: 10m Work Description: robertwb commented on pull request #9915: [BEAM-7746] Add python type hints (part 1) URL: https://github.com/apache/beam/pull/9915#discussion_r347766676 ########## File path: sdks/python/apache_beam/runners/worker/bundle_processor.py ########## @@ -847,16 +993,24 @@ def __init__(self, descriptor, data_channel_factory, counter_factory, runner=beam_fn_api_pb2.StateKey.Runner(key=token)), element_coder_impl)) - _known_urns = {} + _known_urns = {} # type: Dict[str, Tuple[ConstructorFn, Union[Type[message.Message], Type[bytes], None]]] @classmethod - def register_urn(cls, urn, parameter_type): + def register_urn(cls, + urn, # type: str + parameter_type # type: Optional[Type[T]] + ): + # type: (...) -> Callable[[Callable[[BeamTransformFactory, str, beam_runner_api_pb2.PTransform, T, Dict[str, List[operations.Operation]]], operations.Operation]], Callable[[BeamTransformFactory, str, beam_runner_api_pb2.PTransform, T, Dict[str, List[operations.Operation]]], operations.Operation]] Review comment: That's a mouthful... is it possible to have newlines in type declarations? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 346250) Time Spent: 23h 40m (was: 23.5h) > Add type hints to python code > ----------------------------- > > Key: BEAM-7746 > URL: https://issues.apache.org/jira/browse/BEAM-7746 > Project: Beam > Issue Type: New Feature > Components: sdk-py-core > Reporter: Chad Dombrova > Assignee: Chad Dombrova > Priority: Major > Time Spent: 23h 40m > Remaining Estimate: 0h > > As a developer of the beam source code, I would like the code to use pep484 > type hints so that I can clearly see what types are required, get completion > in my IDE, and enforce code correctness via a static analyzer like mypy. > This may be considered a precursor to BEAM-7060 > Work has been started here: [https://github.com/apache/beam/pull/9056] > > -- This message was sent by Atlassian Jira (v8.3.4#803005)