[
https://issues.apache.org/jira/browse/BEAM-8575?focusedWorklogId=346896&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-346896
]
ASF GitHub Bot logged work on BEAM-8575:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Nov/19 17:40
Start Date: 20/Nov/19 17:40
Worklog Time Spent: 10m
Work Description: bumblebee-coming commented on issue #10159: [BEAM-8575]
Added a unit test to CombineTest class to test that Combi…
URL: https://github.com/apache/beam/pull/10159#issuecomment-555710517
The Java parity of this test is:
testHotKeyCombiningWithAccumulationMode
in file:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/CombineTest.java
There are three things to clarify:
1. The Java test used .pane().isLast() to check and then emit the result for
the last pane. This is not necessary. Plus the PaneInfo is not easy to get in
Python, which requires using WindowedValue from apache_beam.utils. So in the
Python code, we compare the result directly.
2. Although the names contain "HotKey", the Java test combines globally, not
combining per key, and uses WithFanout, not WithHotKeyFanout.
3. Since all the elements have the same timestamp, ACCUMULATING or
DISCARDING doesn't change the result. I'm not very sure about the Java test's
intention.
The Python test followed the Java test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 346896)
Time Spent: 13h 40m (was: 13.5h)
> Add more Python validates runner tests
> --------------------------------------
>
> Key: BEAM-8575
> URL: https://issues.apache.org/jira/browse/BEAM-8575
> Project: Beam
> Issue Type: Test
> Components: sdk-py-core, testing
> Reporter: wendy liu
> Assignee: wendy liu
> Priority: Major
> Time Spent: 13h 40m
> Remaining Estimate: 0h
>
> This is the umbrella issue to track the work of adding more Python tests to
> improve test coverage.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
