[ 
https://issues.apache.org/jira/browse/BEAM-8603?focusedWorklogId=347087&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-347087
 ]

ASF GitHub Bot logged work on BEAM-8603:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Nov/19 00:19
            Start Date: 21/Nov/19 00:19
    Worklog Time Spent: 10m 
      Work Description: chamikaramj commented on pull request #10055: 
[BEAM-8603] Add Python SqlTransform example script
URL: https://github.com/apache/beam/pull/10055#discussion_r348841220
 
 

 ##########
 File path: sdks/java/extensions/sql/build.gradle
 ##########
 @@ -24,6 +24,7 @@ plugins {
 }
 applyJavaNature(
   automaticModuleName: 'org.apache.beam.sdk.extensions.sql',
+  shadowClosure: {},
 
 Review comment:
   We need two jars.
   
   (1) Jar for expansion service that contains the transform classes that need 
to be expanded (this can be multiple jars as well, IO transforms just have to 
be in the class path to be picked up by the AutoService).
   (2) Jar to be passed to the Java worker. For me, building a shadow Jar of 
java-harness (:sdks:java:harness:shadowJar) worked.
   
   It probably makes sens to move expansion service to it's own Gradle module 
and support building a shadow jar with all in-built cross-language transforms 
in Beam and release that.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 347087)
    Time Spent: 1h  (was: 50m)

> Add Python SqlTransform example script
> --------------------------------------
>
>                 Key: BEAM-8603
>                 URL: https://issues.apache.org/jira/browse/BEAM-8603
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py-core
>            Reporter: Brian Hulette
>            Assignee: Brian Hulette
>            Priority: Major
>          Time Spent: 1h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to