[
https://issues.apache.org/jira/browse/BEAM-8747?focusedWorklogId=348191&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-348191
]
ASF GitHub Bot logged work on BEAM-8747:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Nov/19 15:35
Start Date: 22/Nov/19 15:35
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on pull request #10172:
[BEAM-8747] Guava dependency cleanup
URL: https://github.com/apache/beam/pull/10172#discussion_r349656312
##########
File path: sdks/java/io/kinesis/build.gradle
##########
@@ -34,6 +34,7 @@ dependencies {
compile library.java.slf4j_api
compile library.java.joda_time
compile library.java.jackson_dataformat_cbor
+ compile library.java.guava
Review comment:
@kennknowles Thank you for details. Yes, there is a known discrepancy
between guava versions used in different Kinesis libs and I believe we test it
sufficiently with unit and integration tests. Though, we still have a task to
move IT into Apache Jenkins env and run it there (the problem that we run it
against real AWS instances but it's another question, not elated to this PR).
Back to initial question, to make it clear - I don't insist, I just asked to
clarify =) And I agree that since we know that it's working we should not worry
too much about that. Kinesis client library is [open
source](https://github.com/awslabs/amazon-kinesis-client), so yes, we can check
it if needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 348191)
Time Spent: 2h 10m (was: 2h)
> Remove Unused non-vendored Guava compile dependencies
> -----------------------------------------------------
>
> Key: BEAM-8747
> URL: https://issues.apache.org/jira/browse/BEAM-8747
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Tomo Suzuki
> Assignee: Tomo Suzuki
> Priority: Major
> Attachments: Guava used as fully-qualified class name.png
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> [~kenn] says:
> BeamModulePlugin just contains lists of versions to ease coordination across
> Beam modules, but mostly does not create dependencies. Most of Beam's modules
> only depend on a few things there. For example Guava is not a core
> dependency, but here is where it is actually depended upon:
> $ find . -name build.gradle | xargs grep library.java.guava
> ./sdks/java/core/build.gradle: shadowTest library.java.guava_testlib
> ./sdks/java/extensions/sql/jdbc/build.gradle: compile library.java.guava
> ./sdks/java/io/google-cloud-platform/build.gradle: compile library.java.guava
> ./sdks/java/io/kinesis/build.gradle: testCompile library.java.guava_testlib
> These results appear to be misleading. Grepping for 'import
> com.google.common', I see this as the actual state of things:
> - GCP connector does not appear to actually depend on Guava in compile scope
> - The Beam SQL JDBC driver does not appear to actually depend on Guava in
> compile scope
> - The Dataflow Java worker does depend on Guava at compile scope but has
> incorrect dependencies (and it probably shouldn't)
> - KinesisIO does depend on Guava at compile scope but has incorrect
> dependencies (Kinesis libs have Guava on API surface so it is OK here, but
> should be correctly declared)
> - ZetaSQL translator does depend on Guava at compile scope but has incorrect
> dependencies (ZetaSQL has it on API surface so it is OK here, but should be
> correctly declared)
> We used to have an analysis that prevented this class of error.
> Once the errors are fixed, the guava_version is simply a version that we have
> discovered that seems to work for both Kinesis and ZetaSQL, libraries we do
> not control. Kinesis producer is built against 18.0. Kinesis client against
> 26.0-jre. ZetaSQL against 26.0-android.
> (or maybe I messed up in my analysis)
> Kenn
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
