[
https://issues.apache.org/jira/browse/BEAM-8338?focusedWorklogId=349786&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-349786
]
ASF GitHub Bot logged work on BEAM-8338:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Nov/19 13:39
Start Date: 26/Nov/19 13:39
Worklog Time Spent: 10m
Work Description: echauchot commented on pull request #10025: [BEAM-8338]
Support ES 7.x for ElasticsearchIO
URL: https://github.com/apache/beam/pull/10025#discussion_r350745236
##########
File path:
sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java
##########
@@ -202,7 +202,7 @@ static void checkForErrors(HttpEntity responseEntity, int
backendVersion, boolea
} else {
if (backendVersion == 2) {
errorRootName = "create";
- } else if (backendVersion == 5 || backendVersion == 6) {
+ } else if (backendVersion == 5 || backendVersion == 6 ||
backendVersion == 7) {
Review comment:
IMHO better ton avoid running on non-tested versions (if we use >)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 349786)
Time Spent: 3.5h (was: 3h 20m)
> Support ES 7.x for ElasticsearchIO
> ----------------------------------
>
> Key: BEAM-8338
> URL: https://issues.apache.org/jira/browse/BEAM-8338
> Project: Beam
> Issue Type: Improvement
> Components: io-java-elasticsearch
> Reporter: Michal Brunát
> Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Elasticsearch has released 7.4 but ElasticsearchIO only supports 2x,5.x,6.x.
> We should support ES 7.x for ElasticsearchIO.
> [https://www.elastic.co/guide/en/elasticsearch/reference/current/index.html]
>
> [https://github.com/apache/beam/blob/master/sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
