[ 
https://issues.apache.org/jira/browse/BEAM-8335?focusedWorklogId=352126&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-352126
 ]

ASF GitHub Bot logged work on BEAM-8335:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Dec/19 19:25
            Start Date: 02/Dec/19 19:25
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on pull request #9720: [BEAM-8335] 
Add initial modules for interactive streaming support
URL: https://github.com/apache/beam/pull/9720#discussion_r352781610
 
 

 ##########
 File path: model/pipeline/src/main/proto/beam_runner_api.proto
 ##########
 @@ -489,33 +490,66 @@ message TestStreamPayload {
   // (Required) the coder for elements in the TestStream events
   string coder_id = 1;
 
+  // (Optional) If specified, the TestStream will replay these events.
   repeated Event events = 2;
 
+  // (Optional) If specified, the TestStream will use the InteractiveService
+  // protocol found in beam_interactive_api.proto to retrieve events.
+  ApiServiceDescriptor endpoint = 3;
+
   message Event {
     oneof event {
       AdvanceWatermark watermark_event = 1;
       AdvanceProcessingTime processing_time_event = 2;
       AddElements element_event = 3;
     }
 
+    // Advances the watermark to the specified timestamp.
     message AdvanceWatermark {
+      // (Required) The watermark to advance to.
       int64 new_watermark = 1;
+
+      // (Optional) The output watermark tag for a PCollection. If unspecified
+      // or with an empty string, this will default to the Main PCollection
+      // Output
+      string tag = 2;
     }
 
+    // Advances the processing time clock by the specified amount.
     message AdvanceProcessingTime {
+      // (Required) The duration to advance by.
       int64 advance_duration = 1;
     }
 
+    // Adds elements to the stream to be emitted.
     message AddElements {
+      // (Required) The elements to add to the TestStream.
       repeated TimestampedElement elements = 1;
+
+      // (Optional) The output PCollection tag to add these elements to. If
+      // unspecified or with an empty string, this will default to the Main
+      // PCollection Output.
+      string tag = 3;
     }
   }
 
+  // A single element inside of the TestStream.
   message TimestampedElement {
+    // (Required) The element encoded. Currently the TestStream only supports
+    // encoding primitives.
     bytes encoded_element = 1;
+
+    // (Required) The event timestamp of this element.
     int64 timestamp = 2;
   }
 }
+
+service TestStreamService {
 
 Review comment:
   Why is this needed?
   
   The current ProcessBundleDescriptor and ProcessBundleRequest can already 
split the execution so that the Runner and the SDK perform their respective 
responsibilities:
   ```
   Runner that is processing and emitting TestStream events -> Data Channel -> 
SDK processing events
   ```
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 352126)
    Time Spent: 37h  (was: 36h 50m)

> Add streaming support to Interactive Beam
> -----------------------------------------
>
>                 Key: BEAM-8335
>                 URL: https://issues.apache.org/jira/browse/BEAM-8335
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-py-interactive
>            Reporter: Sam Rohde
>            Assignee: Sam Rohde
>            Priority: Major
>          Time Spent: 37h
>  Remaining Estimate: 0h
>
> This issue tracks the work items to introduce streaming support to the 
> Interactive Beam experience. This will allow users to:
>  * Write and run a streaming job in IPython
>  * Automatically cache records from unbounded sources
>  * Add a replay experience that replays all cached records to simulate the 
> original pipeline execution
>  * Add controls to play/pause/stop/step individual elements from the cached 
> records
>  * Add ability to inspect/visualize unbounded PCollections



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to