[ https://issues.apache.org/jira/browse/BEAM-8581?focusedWorklogId=353141&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-353141 ]
ASF GitHub Bot logged work on BEAM-8581: ---------------------------------------- Author: ASF GitHub Bot Created on: 04/Dec/19 00:36 Start Date: 04/Dec/19 00:36 Worklog Time Spent: 10m Work Description: rohdesamuel commented on pull request #10035: [BEAM-8581] and [BEAM-8582] watermark and trigger fixes URL: https://github.com/apache/beam/pull/10035#discussion_r353496645 ########## File path: sdks/python/apache_beam/transforms/trigger_test.py ########## @@ -892,91 +862,13 @@ class WeakTestStreamTranscriptTest(BaseTestStreamTranscriptTest): allow_out_of_order = True -class BatchTranscriptTest(TranscriptTest): Review comment: Looks like a bad merge, fixing now. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 353141) Time Spent: 8h 10m (was: 8h) > Python SDK labels ontime empty panes as late > -------------------------------------------- > > Key: BEAM-8581 > URL: https://issues.apache.org/jira/browse/BEAM-8581 > Project: Beam > Issue Type: Bug > Components: sdk-py-core > Reporter: Sam Rohde > Assignee: Sam Rohde > Priority: Major > Time Spent: 8h 10m > Remaining Estimate: 0h > > The GeneralTriggerDriver does not put watermark holds on timers, leading to > the ontime empty pane being considered late data. > Fix: Add a new notion of whether a trigger has an ontime pane. If it does, > then set a watermark hold to end of window - 1. -- This message was sent by Atlassian Jira (v8.3.4#803005)