[ 
https://issues.apache.org/jira/browse/BEAM-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16990289#comment-16990289
 ] 

Jing Chen commented on BEAM-8801:
---------------------------------

[~bhulette] thank you for the explanation.

I am able to pick up the ticket. 

I am working on [BEAM-5504|https://issues.apache.org/jira/browse/BEAM-5504] to 
add avro support for pubsub table, it might benefit from the refactoring.

 

Feel free to let me know if you have any comments :)

> PubsubMessageToRow should not check useFlatSchema() in processElement
> ---------------------------------------------------------------------
>
>                 Key: BEAM-8801
>                 URL: https://issues.apache.org/jira/browse/BEAM-8801
>             Project: Beam
>          Issue Type: Improvement
>          Components: dsl-sql
>            Reporter: Brian Hulette
>            Assignee: Brian Hulette
>            Priority: Major
>
> Currently we check useFlatSchema() for every element that's processed. 
> Instead, we should check it once at pipeline construction time. See 
> [comment|https://github.com/apache/beam/pull/10158#discussion_r348805530].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to