[
https://issues.apache.org/jira/browse/BEAM-8512?focusedWorklogId=356536&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-356536
]
ASF GitHub Bot logged work on BEAM-8512:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Dec/19 20:46
Start Date: 09/Dec/19 20:46
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #10284: [BEAM-8512] Add
integration tests for flink_runner.py.
URL: https://github.com/apache/beam/pull/10284#discussion_r355674855
##########
File path: runners/flink/job-server/flink_job_server.gradle
##########
@@ -90,6 +90,7 @@ dependencies {
runtime project(":sdks:java:io:kafka")
runtime library.java.kafka_clients
runtime project(":sdks:java:io:google-cloud-platform")
+ runtime project(path: flinkRunnerProject, configuration: "miniCluster")
Review comment:
Yes. I think I have to make a separate jar anyway because including
`PortablePipelineJarUtils` in the mini cluster jar seems to break the loading
of the pipeline. I haven't yet figured out how to create multiple shadow jars
with different configurations, however.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 356536)
Time Spent: 3h (was: 2h 50m)
> Add integration tests for Python "flink_runner.py"
> --------------------------------------------------
>
> Key: BEAM-8512
> URL: https://issues.apache.org/jira/browse/BEAM-8512
> Project: Beam
> Issue Type: Test
> Components: runner-flink, sdk-py-core
> Reporter: Maximilian Michels
> Assignee: Kyle Weaver
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> There are currently no integration tests for the Python FlinkRunner. We need
> a set of tests similar to {{flink_runner_test.py}} which currently use the
> PortableRunner and not the FlinkRunner.
> CC [~robertwb] [~ibzib] [~thw]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
