[
https://issues.apache.org/jira/browse/BEAM-7951?focusedWorklogId=356915&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-356915
]
ASF GitHub Bot logged work on BEAM-7951:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Dec/19 09:17
Start Date: 10/Dec/19 09:17
Worklog Time Spent: 10m
Work Description: sunjincheng121 commented on pull request #9979:
[BEAM-7951] Allow runner to configure customization WindowedValue coder.
URL: https://github.com/apache/beam/pull/9979#discussion_r355920245
##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -1059,6 +1066,17 @@ message SideInput {
SdkFunctionSpec window_mapping_fn = 3;
}
+// Settings that decide the coder type of wire coder.
+message WireCoderSetting {
+ // (Required) The URN of the wire coder.
+ // Note that only windowed value coder or parameterized windowed value coder
are supported.
+ string urn = 1;
+
+ // (Optional) The data specifying any parameters to the URN. If
+ // the URN does not require any arguments, this may be omitted.
+ bytes payload = 2;
Review comment:
We can get the element coder id and window coder id like the same way of the
current windowed value coder. The element coder and window coder can be used to
encode and decode the payload. For example, in WireCoders, the elementCoderId
and
windowCoderId are get from PCollectionNode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 356915)
Time Spent: 5.5h (was: 5h 20m)
> Allow runner to configure customization WindowedValue coder such as
> ValueOnlyWindowedValueCoder
> -----------------------------------------------------------------------------------------------
>
> Key: BEAM-7951
> URL: https://issues.apache.org/jira/browse/BEAM-7951
> Project: Beam
> Issue Type: Sub-task
> Components: java-fn-execution
> Reporter: sunjincheng
> Assignee: sunjincheng
> Priority: Major
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> The coder of WindowedValue cannot be configured and it’s always
> FullWindowedValueCoder. We don't need to serialize the timestamp, window and
> pane properties in Flink and so it will be better to make the coder
> configurable (i.e. allowing to use ValueOnlyWindowedValueCoder)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
