[ https://issues.apache.org/jira/browse/BEAM-8917?focusedWorklogId=360144&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-360144 ]
ASF GitHub Bot logged work on BEAM-8917: ---------------------------------------- Author: ASF GitHub Bot Created on: 16/Dec/19 09:48 Start Date: 16/Dec/19 09:48 Worklog Time Spent: 10m Work Description: iemejia commented on issue #10370: [release-2.17.0][BEAM-8917][BEAM-8967] jsr305 dependency declaration for Nullable class (#10324) URL: https://github.com/apache/beam/pull/10370#issuecomment-565984823 Run SQL postcommit ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 360144) Time Spent: 11.5h (was: 11h 20m) > javax.annotation.Nullable is missing for > org.apache.beam.sdk.schemas.FieldValueTypeInformation > ---------------------------------------------------------------------------------------------- > > Key: BEAM-8917 > URL: https://issues.apache.org/jira/browse/BEAM-8917 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core > Reporter: Tomo Suzuki > Assignee: Tomo Suzuki > Priority: Major > Fix For: 2.17.0 > > Time Spent: 11.5h > Remaining Estimate: 0h > > This ticket is from the result of static analysis by Linkage Checker > ([detail|https://github.com/GoogleCloudPlatform/cloud-opensource-java/issues/1045]) > h1. Example Project > Example project to produce an issue: > https://github.com/suztomo/beam-java-sdk-missing-nullable . > I think the Maven artifact {{org.apache.beam:beam-sdks-java-core}}, which > contains {{org.apache.beam.sdk.schemas.FieldValueTypeInformation}}, should > declare the dependency to {{com.google.code.findbugs:jsr305}}. > h1. Why there's no problem in compilation and tests of sdks/java/core? > The compilation succeeds because the {{Nullable}} annotation is in the > transitive dependency of compileOnly {{spotbugs-annotations}} dependency: > {noformat} > compileOnly - Compile only dependencies for source set 'main'. > ... > +--- com.github.spotbugs:spotbugs-annotations:3.1.12 > | \--- com.google.code.findbugs:jsr305:3.0.2 > ... > {noformat} > The tests succeed because the {{Nullable}} annotation is in the transitive > dependency of {{guava-testlib}}. > {noformat} > testRuntime - Runtime dependencies for source set 'test' (deprecated, use > 'testRuntimeOnly' instead). > ... > +--- com.google.guava:guava-testlib:20.0 > | +--- com.google.code.findbugs:jsr305:1.3.9 > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)