[
https://issues.apache.org/jira/browse/BEAM-5495?focusedWorklogId=360384&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-360384
]
ASF GitHub Bot logged work on BEAM-5495:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Dec/19 17:18
Start Date: 16/Dec/19 17:18
Worklog Time Spent: 10m
Work Description: lgajowy commented on issue #10268: [BEAM-5495]
PipelineResources algorithm is not working in most environments
URL: https://github.com/apache/beam/pull/10268#issuecomment-566156575
I believe that it may be worth keeping the pr in history. It introduces
another (valid) way of how we can do classpath scanning in java >=9 that I've
seen in other projects. In case we have any problems with classgraph, we can
revert to that version easily (as easy as `git revert 7e5a885` - the commit
that introduces classgraph).
I could still squash that - it will be a little bit tricky due to another
commit relying on the changes but I think I can deal with the conflicts. Should
I do this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 360384)
Time Spent: 14h 10m (was: 14h)
> PipelineResources algorithm is not working in most environments
> ---------------------------------------------------------------
>
> Key: BEAM-5495
> URL: https://issues.apache.org/jira/browse/BEAM-5495
> Project: Beam
> Issue Type: Bug
> Components: runner-flink, runner-spark, sdk-java-core
> Reporter: Romain Manni-Bucau
> Assignee: Lukasz Gajowy
> Priority: Major
> Time Spent: 14h 10m
> Remaining Estimate: 0h
>
> Issue are:
> 1. it assumes the classloader is an URLClassLoader (not always true and java
> >= 9 breaks that as well for the app loader)
> 2. it uses loader.getURLs() which leads to including the JRE itself in the
> staged file
> Looks like this detect resource algorithm can't work and should be replaced
> by a SPI rather than a built-in and not extensible algorithm. Another valid
> alternative is to just drop that "guess" logic and force the user to set
> staged files.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
